Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design/new data source+query editor #2185

Merged
merged 84 commits into from
Jan 18, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
8a11183
Add data source logos
kocsmy Dec 10, 2017
c147d30
Separate Data source panel, freely expanding schema browser, freely e…
kocsmy Dec 12, 2017
816c619
Recreate new 2 column layout
kocsmy Dec 13, 2017
439cc45
Merge branch 'master' into design/query-page-improvements
kocsmy Dec 13, 2017
d37948f
Merge branch 'master' into design/new-data-source-flow
kocsmy Dec 17, 2017
0f31de3
General styling improvements
kocsmy Dec 17, 2017
e2df12e
Merge branch 'design/query-page-improvements' into design/new-data-so…
kocsmy Dec 17, 2017
64c69ee
Foundation for New Data Source layout added
kocsmy Dec 17, 2017
0810c2b
Change to narrow layout
kocsmy Dec 18, 2017
9ac5d58
flexible layout v0.1 (WIP)
kocsmy Dec 18, 2017
1110e65
Load all images from images folder
kocsmy Dec 19, 2017
5441ef4
Fix card sizes
kocsmy Dec 19, 2017
404000e
Add missing elements for new data source screen
kocsmy Dec 19, 2017
e6f8b2c
Flexible query editor
kocsmy Dec 20, 2017
24188ab
Perfectly calculated schema-container size, finally
kocsmy Dec 21, 2017
708cc26
Cleaning up code and properly fall back design on narrower screen for…
kocsmy Dec 26, 2017
696eefa
Further cleaning up code
kocsmy Dec 26, 2017
0a15986
Code and styling improvements focusing on xs and sm screen sizes
kocsmy Dec 26, 2017
3c9f59b
Adjust button size size so it's consistent
kocsmy Dec 26, 2017
db6c876
Further refining code and removing junk
kocsmy Dec 26, 2017
e925568
Further improve smaller screen design
kocsmy Dec 26, 2017
a698cb0
Pluralize database
kocsmy Dec 27, 2017
3bc5c60
better data source cars + list view has cards now, too
kocsmy Dec 27, 2017
e6ec50a
Dynamic forms back live again, extra classes added for better form de…
kocsmy Dec 27, 2017
635aeb3
Remove classes
kocsmy Dec 27, 2017
f2585d1
Better edit in place and other refinements for rearranged layout
kocsmy Dec 27, 2017
52bae5c
Rearrange elements for better UX
kocsmy Dec 27, 2017
58eb08e
Refine format and other smaller elements
kocsmy Dec 27, 2017
c9d5347
mobile and spacing fixes
kocsmy Dec 27, 2017
f258d80
Add border for editor
kocsmy Dec 29, 2017
3b232d3
Fixing resizing issues
kocsmy Dec 29, 2017
ecc6200
Refining styling so resize works nicely
kocsmy Dec 29, 2017
4d0a6ac
More css for better collapse and expand
kocsmy Dec 29, 2017
a26dbab
Merge branch 'master' of https://github.com/getredash/redash into des…
kocsmy Jan 3, 2018
694115e
Fix unsaved query table visualisation
kocsmy Jan 3, 2018
7ce815c
Better alignment
kocsmy Jan 3, 2018
7605032
Fix filters so it'll nicely list 2+ filters
kocsmy Jan 3, 2018
d8594e7
Fix misplaced div closing tags
kocsmy Jan 3, 2018
2a3c759
Refine styling and fixes
kocsmy Jan 3, 2018
33a2271
Smaller styling improvements
kocsmy Jan 3, 2018
20c3ad2
Merge branch 'master' into design/new-data-source+query-editor
arikfr Jan 4, 2018
ca893a0
Rename db logos to their correct names
arikfr Jan 4, 2018
9afd23a
Use actual data source types + filtering
arikfr Jan 4, 2018
59af40f
Switch to dev.redashapp.com as the dev server
arikfr Jan 4, 2018
3b14958
Working data source setup pages
arikfr Jan 4, 2018
56ffb1f
Update alert destination to use new design
arikfr Jan 4, 2018
bae4016
Remove ng-app directive in query page
arikfr Jan 4, 2018
ea1334e
Make results mode hide query editing parts
arikfr Jan 4, 2018
f91bc2a
add athena logo
kocsmy Jan 4, 2018
e29e4bf
Make org settings layout better
kocsmy Jan 5, 2018
7d16cd2
Remove unnecessary classes
kocsmy Jan 5, 2018
f6ac9c4
Multiple new data source and alert refinements for layout and styling
kocsmy Jan 5, 2018
f231365
Remove duplicate datasource selector
kocsmy Jan 5, 2018
9850908
Fixing empty query resize issues
kocsmy Jan 5, 2018
eb9b313
Better aligned and spaced cards
kocsmy Jan 5, 2018
d1de26b
Small screen fixes
kocsmy Jan 5, 2018
ef202e7
Close #2159: special tab for your own user profile
arikfr Jan 7, 2018
a3dec53
Replacing icons
kocsmy Jan 7, 2018
46061a0
Merge branch 'master' into design/new-data-source+query-editor
kocsmy Jan 7, 2018
c120898
Refine logos + the header of 2nd step for adding new data source
kocsmy Jan 7, 2018
c0fb51f
Multiple styling fixes
kocsmy Jan 7, 2018
efede57
Update org settings layout
arikfr Jan 8, 2018
55b852f
Hide query metadata for unsaved queries
arikfr Jan 8, 2018
5b938f2
Add layouts support.
arikfr Jan 9, 2018
3359ab2
Mark required fields in dynamic forms
arikfr Jan 9, 2018
7c4b66b
Rename show / hide source
kocsmy Jan 9, 2018
192ddd2
Better required * indication without red color
kocsmy Jan 9, 2018
d24a5bd
Smaller screen improvements for new data source flow
kocsmy Jan 9, 2018
5189e6d
Overwrite instead of writing new code
kocsmy Jan 9, 2018
28cc7ea
Attach result controls to the bottom of the query page
kocsmy Jan 9, 2018
ffbf245
Fix minor styling issues
kocsmy Jan 9, 2018
6ce8883
More descriptive button text for edit visualisation
kocsmy Jan 9, 2018
3a413b5
Fix: embed/edit buttons were not working
arikfr Jan 9, 2018
f3014f5
Further styling fixes
kocsmy Jan 9, 2018
98d0f05
Merge branch 'design/new-data-source+query-editor' of https://github.…
kocsmy Jan 9, 2018
ceb966a
Merge branch 'master' into design/new-data-source+query-editor
arikfr Jan 11, 2018
bc29c12
Properly handle 1row
arikfr Jan 11, 2018
75d0d2d
Show data scanned property when available
arikfr Jan 11, 2018
7ba5cc5
move updated at time to the right
kocsmy Jan 14, 2018
e04729a
Plenty of improvements based on #2185 comments
kocsmy Jan 14, 2018
45c75a8
Smaller fixes for smaller screens
kocsmy Jan 14, 2018
ca69a24
cleanup css
kocsmy Jan 14, 2018
612710f
Fix Firefox issue
kocsmy Jan 14, 2018
11cfc66
Add Redash styling to editor
kocsmy Jan 15, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added client/app/assets/images/db-logos/athena.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/axibasetsd.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/bigquery.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/clickhouse.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/cockroach.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/graphite.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/hive.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/impala.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/influxdb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/jirajql.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/kibana.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/memsql.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/mongodb.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/mssql.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/mysql.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/pg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/presto.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/rds_mysql.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/redshift.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/results.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/salesforce.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added client/app/assets/images/db-logos/sqlite.png
Binary file added client/app/assets/images/db-logos/url.png
Binary file added client/app/assets/images/db-logos/vertica.png
Binary file added client/app/assets/images/destinations/email.png
Binary file added client/app/assets/images/destinations/hipchat.png
Binary file added client/app/assets/images/destinations/webhook.png
39 changes: 38 additions & 1 deletion client/app/assets/less/inc/edit-in-place.less
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
.edit-in-place span {
white-space: pre-line;

p {
margin-bottom: 0;
}
}

.edit-in-place span.editable {
cursor: pointer;
}

.edit-in-place span.editable:hover {
background: #FCFCA2;
background: @redash-yellow;
border-radius: @redash-radius;
}

.edit-in-place input,
Expand All @@ -24,3 +29,35 @@
display: inline-block;
}

.edit-in-place {
display: inline-block;
}

.edit-in-place {
.rd-form-control {
padding: 0px 6px;
width: 30vw;
}

&.active {
textarea.rd-form-control {
height: 29px;
width: 40vw;
}
}
}


@media (max-width: 880px) {
.edit-in-place {
.rd-form-control {
width: 50vw;
}

&.active {
textarea.rd-form-control {
width: 50vw;
}
}
}
}
4 changes: 2 additions & 2 deletions client/app/assets/less/inc/form.less
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ textarea.v-resizable {
&.required {
.control-label {
&:after {
content: "*";
color: red;
content: " *";
color: inherit;
}
}
}
Expand Down
Loading