Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete waste space above show/hide source button #2182

Closed
wants to merge 1 commit into from
Closed

Delete waste space above show/hide source button #2182

wants to merge 1 commit into from

Conversation

kyoshidajp
Copy link
Member

Summary

Delete waste space above Show/Hide Source button at query page when page width is narrow.

waste_space

Screencasts

Before

before_source_button_layout mov

After

after_source_button_layout mov

@arikfr
Copy link
Member

arikfr commented Dec 28, 2017

@kocsmy I'm assuming you will address this as part of the changes in #2185, right?

@kocsmy
Copy link
Collaborator

kocsmy commented Dec 28, 2017

Yes, this fix won't be necessary once we roll out the new Query editor.

@kyoshidajp
Copy link
Member Author

@arikfr @kocsmy Thanks. I'll close this.

@kyoshidajp kyoshidajp closed this Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyoshidajp @arikfr @kocsmy