Calculate version correctly when multiple tags are present #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple tags are present on the same commit, the version was calculated incorrectly. E.g., when `latest`, `canary` and `v1.1.0` tags are present on the same commit, the command seems to sort alphabetically causing the version to always be set to `canary`. This behaviour breaks makes it impossible to release a finalized version, e.g., `v1.1.0`. Using matching results in the version being calculated from the latest released version. The version will look like this `v1.1.0-2-gf3862833` instead of `canary`. Signed-off-by: Kim Christensen <kmch@simcorp.com>
45e5f13 to
f605ad4
Compare
schristoff
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple tags are present on the same commit, the version was calculated incorrectly. E.g., when
latest,canaryandv1.1.0tags are present on the same commit, the command seems to sort alphabetically causing the version to always be set tocanary. This behaviour breaks makes it impossible to release a finalized version, e.g.,v1.1.0.Using matching results in the version being calculated from the latest released version. The version will look like this
v1.1.0-2-gf3862833instead ofcanarywhen running a canary build.