Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importer fixes #3221

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Importer fixes #3221

merged 2 commits into from
Oct 28, 2023

Conversation

avaris
Copy link
Member

@avaris avaris commented Oct 28, 2023 •
edited
Loading

  • Force UTC for date conversion in tumblr importer with offset and adjust tests
  • Use a temporary file for the intermediate HTML file during conversion
  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

justinmayer
justinmayer approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for these fixes, @avaris! 🌟

@justinmayer justinmayer merged commit 6ed7395 into getpelican:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

Assignees

@justinmayer justinmayer

Labels
None yet
Projects
Pelican Sprint 2023
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avaris @justinmayer