Skip to content

Commit

Permalink
SelectField: selected values are **filtered** from value state on ite…
Browse files Browse the repository at this point in the history
…mset change

This addresses a temporary regression in an earlier commit laying groundwork for engineDOMAdapter integration. The nature of the change is best described by #57

Some previously failing scenario tests now pass. And some new tests are added to clarify the change in behavior.

**NOTE:** this change is not intended to press for a decision on #57. It is primarily meant to ensure that, to the best of my knowledge, this refactor does not have any known regressions (excepting some edge cases discussed in previous commit notes). Secondarily, it’s meant to leave some better breadcrumbs for us to make an informed decision on that issue when we do prioritize it.
  • Loading branch information
eyelidlessness committed Nov 4, 2024
1 parent 08019cc commit d55ce0c
Show file tree
Hide file tree
Showing 2 changed files with 271 additions and 184 deletions.
Loading

0 comments on commit d55ce0c

Please sign in to comment.