Skip to content

Commit

Permalink
scenario (fix): adjust for change to engine SubmissionResult types
Browse files Browse the repository at this point in the history
This isn’t a great sign about the engine-side change. I’m going ahead with it to get this into review quickly, unblocking both the Central integration and my ability to get back to reviewing other work in flight.

I think it’s okay to just remove this parameter for now, because there won’t be tests exercising chunked submissions until we support `<upload>` and submission attachments.
  • Loading branch information
eyelidlessness committed Jan 24, 2025
1 parent 46a1f1e commit c60e37a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions packages/scenario/src/jr/Scenario.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ import type {
RepeatRangeUncontrolledNode,
RootNode,
SelectNode,
SubmissionChunkedType,
SubmissionOptions,
SubmissionResult,
} from '@getodk/xforms-engine';
import { constants as ENGINE_CONSTANTS } from '@getodk/xforms-engine';
import type { Accessor, Setter } from 'solid-js';
Expand Down Expand Up @@ -965,10 +962,8 @@ export class Scenario {
* more about Collect's responsibility for submission (beyond serialization,
* already handled by {@link proposed_serializeInstance}).
*/
prepareWebFormsSubmission<ChunkedType extends SubmissionChunkedType>(
options?: SubmissionOptions<ChunkedType>
): Promise<SubmissionResult<ChunkedType>> {
return this.instanceRoot.prepareSubmission<ChunkedType>(options);
prepareWebFormsSubmission() {
return this.instanceRoot.prepareSubmission();
}

// TODO: consider adapting tests which use the following interfaces to use
Expand Down

0 comments on commit c60e37a

Please sign in to comment.