Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #564

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Dependency updates #564

merged 2 commits into from
Dec 13, 2023

Conversation

lognaturel
Copy link
Member

Closes #497

What has been done to verify that this works as intended?

  • Ran the updated smtp image on Digital Ocean and verified email sending attempts work the same way
  • Reviewed the nginx-certbot diff and verified that there are no changes to redirector.conf. Put upgrade on dev server

Changes are fairly minimal for the nginx-certbot image, there just is one technically breaking change.

Why is this the best possible solution? Were any other approaches considered?

Uses latest versions.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Neither upgrade looks very risky.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@matthew-white matthew-white self-requested a review December 12, 2023 22:20
@lognaturel lognaturel merged commit 58b81c6 into next Dec 13, 2023
@lognaturel lognaturel deleted the dependency-updates branch December 13, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants