Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh keys when refreshing submissions #910

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 11, 2023

Closes #521

When submissions are refreshed, if we might need to refetch an encryption key (if the form is encrypted and we have no keys at the moment), then the submission list component will emit an event to the parent component, which is already responsible for the initial key request, to refetch the key.

What has been done to verify that this works as intended?

Tests

Why is this the best possible solution? Were any other approaches considered?

Keys are loaded in two places, maybe that's not great.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should fix an issue, shouldn't really be any risks. Keys (a small chunk of data) are fetched more often now, but in a way that seems necessary and useful.

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white December 11, 2023 19:41
@ktuite ktuite force-pushed the ktuite/refresh_keys branch from e5e3e3f to 67e7907 Compare December 12, 2023 00:21
Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review with @matthew-white

@ktuite ktuite merged commit 551adce into master Dec 12, 2023
@matthew-white matthew-white deleted the ktuite/refresh_keys branch December 12, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh submission keys in more cases
2 participants