-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #911: add warning to encryption popup #838
fixes #911: add warning to encryption popup #838
Conversation
<p>{{ $t('steps[0].introduction[1][1][1]') }}</p> | ||
</div> | ||
<div class="info-item"> | ||
<span class="icon-close"></span> | ||
<p>{{ $t('steps[0].introduction[1][2][0]') }}</p> | ||
<p>{{ $t('steps[0].introduction[1][2][1]') }}</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's reasonable to remove this explanatory text. There are more items in the modal than there used to be, so I think it's a good idea to remove non-essential text. CC @lognaturel for a second opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do remove this explanatory text, we should also remove the i18n messages below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m pro removing all “in future” text. I think it’s more confusing than helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Existing Submissions will remain unencrypted." seems like a useful caveat to me, but I don't think we need "Encryption cannot be turned off once enabled."
Looks great! 💯 Even though there will be just one list, could you try to preserve the structure/order of the messages in the i18n JSON? Otherwise translations will be removed in Transifex. Or you could use a |
Related to getodk/central-backend#911
Show warning that "Draft Submissions from all Forms will be deleted."
I took the liberty to remove "In future" texts as well, I can add them back if everyone want that.
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes