Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help dropdown to navbar #398

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Add help dropdown to navbar #398

merged 2 commits into from
Dec 16, 2020

Conversation

matthew-white
Copy link
Member

Closes #350.

<a href="https://forum.getodk.org/" target="_blank">{{ $t('forum') }}</a>
</li>
<li>
<a href="/version.txt" target="_blank">{{ $t('version') }}</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will only work if using our Docker setup, right? It feels like Frontend shouldn't have that requirement. I wonder whether there maybe should be a pre-emptive query and the link is only shown if it's available?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's possible, but it's definitely more work. Do you have a use case in mind that doesn't use our Docker setup?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I guess we can make a note in the user documentation. It's true that we don't know of folks deploying frontend without the Docker setup.

@lognaturel
Copy link
Member

lognaturel commented Dec 16, 2020

It feels like the dropdown should expand towards the right rather than the left but I don't feel strongly about it. On the other hand it's nice that it's consistent with the language dropdown. 🤷🏻‍♀️

@matthew-white
Copy link
Member Author

It feels like the dropdown should expand towards the right rather than the left but I don't feel strongly about it.

My instinct is that if the help dropdown expands towards the right, then the locale dropdown should as well. However, the locale dropdown is too wide to do so, so I think I'd lean toward keeping the help dropdown as-is. What do you think? If you want to take a look at what it would look like as it expands towards the right, try adding the dropdown-menu-left class to the ul!

@matthew-white
Copy link
Member Author

Oh just saw your comment update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add navbar links to get help
2 participants