Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show offline entity backlog events and unknown events #1080

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 6, 2024

Related to backend PR getodk/central-backend#1332

It used to be that any unknown action defaulted to showing up as a comment. I've changed it to make it show the text of the action... and also a clock icon. It should probably be a more generic icon, but the clock goes with the specific "unknown" audit actions I'm targeting but don't feel like making special cases of yet.

Screenshot 2024-12-06 at 6 48 50 PM

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to user documentation? If so, please file an issue here and include the link below.

Before submitting this PR, please make sure you have:

  • run npm run test and npm run lint and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite marked this pull request as ready for review December 6, 2024 01:07
@ktuite ktuite requested a review from matthew-white December 6, 2024 01:07
ktuite

This comment was marked as resolved.

@matthew-white matthew-white changed the title handle unknown action and display it Show offline entity backlog events and unknown events Dec 7, 2024
@matthew-white matthew-white merged commit 92c5e4c into master Dec 7, 2024
1 check passed
@matthew-white matthew-white deleted the ktuite/submissionActivityFeed branch December 7, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants