Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add infinite scroll to Entities table #741

Closed
ktuite opened this issue Feb 23, 2023 · 10 comments · Fixed by #851
Closed

Add infinite scroll to Entities table #741

ktuite opened this issue Feb 23, 2023 · 10 comments · Fixed by #851
Assignees
Labels
enhancement New feature or behavior entities Multiple Encounter workflows

Comments

@ktuite
Copy link
Member

ktuite commented Feb 23, 2023

For v2023.2, we are just loading the entire block of entities to show in the entity table. For the following release, when we likely add bulk CSV managing of entities, we will want to add the same kind of chunking and infinite scroll that we have for submissions.

We will likely want to reuse functionality from the submission chunking/scrolling and make a generic infinite scroll odata table.

Note about infinite scroll vs. paging: one use case we see in practice is loading a bunch of submissions and then searching on the page itself for specific content. This is a pretty good case for sticking with infinite scroll until we have the ability to search submission/entity content.

@github-project-automation github-project-automation bot moved this to 🕒 backlog in ODK Central Feb 23, 2023
@matthew-white matthew-white added the enhancement New feature or behavior label Feb 23, 2023
@ktuite ktuite added the entities Multiple Encounter workflows label Mar 20, 2023
@matthew-white matthew-white self-assigned this Mar 23, 2023
@matthew-white
Copy link
Member

Alongside this, I think we should use the useChunkyArray() composable with the entities table, as we do with the submissions table.

@matthew-white matthew-white added the blocked Blocked by other work label May 28, 2023
@matthew-white
Copy link
Member

This issue is currently blocked by getodk/central-backend#665.

@matthew-white
Copy link
Member

I think we should use the useChunkyArray() composable with the entities table

That could happen as part of #851, but I also think it'd be fine for it to happen separately (even in .5).

@matthew-white matthew-white removed the blocked Blocked by other work label Sep 11, 2023
sadiqkhoja added a commit that referenced this issue Sep 12, 2023
)

* Feature #741: Use opaque cursor on submission list and entity list

* move loading message to a new component

* revert default top value

* fix the test

* added composable tn()
@github-project-automation github-project-automation bot moved this from ✏️ in progress to ✅ done in ODK Central Sep 12, 2023
@dbemke
Copy link

dbemke commented Sep 14, 2023

Is it ready for testing?

@sadiqkhoja
Copy link
Contributor

yes

@matthew-white
Copy link
Member

@sadiqkhoja, is there anything you think the QA team should look at specifically while verifying this change? Maybe cases related to concurrent modification? (Just a thought.)

I'm wondering whether it'd be helpful for you to create an entity list on staging with 1,000 or 2,000 entities — something that the QA team could use to verify this change. Alternatively, I think the QA team knows how to create an entity using the API and Postman. If you could show them a way in Postman or another tool to send many requests (in a loop?), then they could create their own large entity list. (One day we'll have bulk upload, and this will be easier!)

@sadiqkhoja
Copy link
Contributor

I will meet with QA team to show them how to use Postman for bulk operations

@srujner
Copy link

srujner commented Sep 15, 2023

Tested with Success!

@dbemke
Copy link

dbemke commented Sep 15, 2023

Tested with success!

@matthew-white
Copy link
Member

matthew-white commented Sep 18, 2023

@sadiqkhoja, @dbemke left a comment here that I'm thinking may be related to the changes for this issue.

@matthew-white matthew-white moved this from ✅ done to ✏️ in progress in ODK Central Sep 18, 2023
@matthew-white matthew-white moved this from ✏️ in progress to ✅ done in ODK Central Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or behavior entities Multiple Encounter workflows
Projects
Status: ✅ done
Development

Successfully merging a pull request may close this issue.

5 participants