Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-migrations: include details from Postgres errors #1415

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Feb 19, 2025

Noticed while working on #1363.

Currently, when a postgres error has additional details, run-migrations.js will swallow these details.

Example

migration

module.exports = {
  down: () => {},
  up: db => db.raw(`
    INSERT INTO config (key) VALUES('a');
    INSERT INTO config (key) VALUES('a');
  `),
}

logging - master

Error: INSERT INTO config (key) VALUES('a'); INSERT INTO config (key) VALUES('a') - duplicate key value violates unique constraint "config_pkey"

logging - this PR

Error: INSERT INTO config (key) VALUES('a'); INSERT INTO config (key) VALUES('a') - duplicate key value violates unique constraint "config_pkey" (Key (key)=(a) already exists.)

What has been done to verify that this works as intended?

Tested locally.

Why is this the best possible solution? Were any other approaches considered?

This can make narrowing down specific problems with migrations easier if the thrown error contains a .detail.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Should not affect users.

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Should not required documentation updates.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant