test/integration: allow use of this.timeout() in FullTrx tests #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to use of `function()` in the test wrappers, `this` was unbound from the real test functions. This PR re-binds mocha's `this` to the test functions, allowing use of e.g. `this.timeout(...)` in individual "FullTrx" tests.
matthew-white
approved these changes
Feb 14, 2025
alxndrsn
pushed a commit
to alxndrsn/odk-central-backend
that referenced
this pull request
Feb 19, 2025
Follow-up to getodk#1402 Noticed while investigating getodk#1403 Due to use of `function()` in the test wrappers, `this` was unbound from the real test functions. This PR re-binds mocha's `this` to the test functions, allowing use of e.g. `this.timeout(...)` in individual tests.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to use of
function()in the test wrappers,thiswas unbound from the real test functions. This PR re-binds mocha'sthisto the test functions, allowing use of e.g.this.timeout(...)in individual "FullTrx" tests.