cypto.getPrivate(): fix error when passphrase kinda works #1386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1212
Sometimes an incorrect passphrase can still "successfully" decrypt supplied the supplied ciphertext, but to nonsense. In this case, the call to
createPrivateKey()
will throw an error that was not previously handled by the surrounding try/catch block.What has been done to verify that this works as intended?
Added tests.
Why is this the best possible solution? Were any other approaches considered?
The full error generated can be:
Checking
error.code
seems like it should be reasonably stable.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should reduce 500 errors or similar.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Hopefully not.
Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes