Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submissions/attachments: demonstrate current null Content-Type handling #1352

Conversation

alxndrsn
Copy link
Contributor

This probably isn't the desired behaviour, but it is the current behaviour.

Copy link
Member

@lognaturel lognaturel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this codebase has a ton of comments with links to issues, the expectation is generally to use git blame or equivalent to get context. I don't personally feel strongly about consistency on that point but wanted to flag it in case others have thoughts.

@ktuite
Copy link
Member

ktuite commented Jan 11, 2025

I'm ok with these references to the issues even if it's a little redundant and git blame could show the trail. (Sometimes just referred to by the issue number, like c#1351.) We have a few sprinkled throughout the code base, especially for tests added to demonstrate specific issues rather than being part of a fix or feature.

I don't think this codebase has a ton of comments with links to issues, the expectation is generally to use git blame or equivalent to get context. I don't personally feel strongly about consistency on that point but wanted to flag it in case others have thoughts.

@alxndrsn alxndrsn merged commit 26cd17e into getodk:master Jan 13, 2025
6 checks passed
@alxndrsn alxndrsn deleted the test-current-null-submission-attachment-content-type branch January 13, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants