API documentation inconsistencies

[alxndrsn]

There are two API endpoints which are documented, but do not seem to correspond to real routes in code:

GET    /v1/test/:key/projects/:id/forms/:id/attachments/:name
PATCH  /v1/projects/:id/forms/:id/draft/submissions/:id/attachments/:name

cc @matthew-white

[matthew-white]

GET    /v1/test/:key/projects/:id/forms/:id/attachments/:name

It looks like this should be .../draft/attachments/:name:

central-backend/lib/resources/forms.js

Line 441 in 428ebdd

service.get('/test/:key/projects/:projectId/forms/:id/draft/attachments/:name', endpoint((container, { params }, request, response) => {

PATCH  /v1/projects/:id/forms/:id/draft/submissions/:id/attachments/:name

I'm pretty sure we only POST to submission attachment endpoints, not PATCH.

central-backend/lib/resources/submissions.js

Lines 417 to 418 in 428ebdd

	service.post(
	`${base}/:instanceId/attachments/:name`,

central-backend/lib/resources/submissions.js

Line 523 in 428ebdd

dataOutputs('/projects/:projectId/forms/:formId/draft/submissions', true, (params, Forms) =>

[matthew-white]

PATCH  /v1/projects/:id/forms/:id/draft/submissions/:id/attachments/:name

I'm actually not seeing this one in the docs anywhere. Maybe we fixed it already? @alxndrsn, let me know if I'm missing something and you still see it in the docs.