Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO-admin: Add basic inline policy crud operations #7182

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

joelmccoy
Copy link
Contributor

Implemented basic CRUD operations for the following sso-admin methods:

Additionally renamed the the exception ResourceNotFound to ResourceNotFoundException to comply with the proper name for the exception (SSOAdmin.Client.exceptions.ResourceNotFoundException)

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea47ba7) 95.90% compared to head (8b2c4a2) 95.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7182   +/-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files         840      840           
  Lines       82512    82539   +27     
=======================================
+ Hits        79134    79161   +27     
  Misses       3378     3378           
Flag Coverage Δ
servertests 35.47% <27.27%> (-0.01%) ⬇️
unittests 95.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers changed the title Add basic inline policy crud operations to sso-admin SSO-admin: Add basic inline policy crud operations Jan 3, 2024
@bblommers bblommers added this to the 4.2.13 milestone Jan 3, 2024
@bblommers bblommers merged commit 5fadeb8 into getmoto:master Jan 3, 2024
37 checks passed
@moto-payments-app
Copy link

Hi @joelmccoy,

Thank you for contributing all these features to Moto!

To show our thanks, we'd like to share some of the donations that we've received with you. PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, get to share the spoils.

We've created a companion website with more information:
https://payments.getmoto.org/

Feel free to open a bug or discussion if you run into any problems:
https://github.com/getmoto/payments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants