-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add language
option
#301
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request introduces a new "Add Language" menu item in the NavBar component's language selection menu. This addition is marked as a work-in-progress (WIP) and appears in both logged-in and logged-out user contexts. The new menu item is currently configured to call the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/components/molecules/NavBar.tsx (2)
379-387
: Clarify the "Add Language" workflowCurrently, the “Add Language” menu item specifically changes the language to German (
de
) while the code comment suggests eventually linking to i18n documentation or a more complete language-adding workflow. Consider updating this to reflect the final plan (e.g., linking to docs or prompting the user to select a new language).
474-482
: Align the "Add Language" item with the final intended functionalityLike its logged-in counterpart, the “Add Language” menu item in the logged-out menu also forcibly sets the language to German. If you aim to provide a discovery path for adding or enabling new languages in the future, refactor this to direct users to the relevant docs or a form where they can propose or search for new languages.
Summary by CodeRabbit