fix: instantiate default HTTPException with empty constructor

getlarge · Feb 6, 2024 · a542cbd · a542cbd
1 parent e7e5e53
commit a542cbd
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 13 deletions.
diff --git a/packages/keto-client-wrapper/src/lib/ory-authorization.guard.ts b/packages/keto-client-wrapper/src/lib/ory-authorization.guard.ts
@@ -22,8 +22,8 @@ export interface OryAuthorizationGuardOptions {
 }
 
 const defaultOptions: OryAuthorizationGuardOptions = {
-  unauthorizedFactory: (ctx, error) => {
-    return new ForbiddenException(error);
+  unauthorizedFactory: () => {
+    return new ForbiddenException();
   },
 };
 
@@ -43,7 +43,7 @@ export const OryAuthorizationGuard = (
       if (!factories?.length) {
         return true;
       }
-      const { unauthorizedFactory } = {
+      const { postCheck, unauthorizedFactory } = {
         ...defaultOptions,
         ...options,
       };
@@ -60,13 +60,13 @@ export const OryAuthorizationGuard = (
         } catch (error) {
           throw unauthorizedFactory(context, error);
         }
-        if (options.postCheck) {
-          options.postCheck(relationTuple, isPermitted);
+        if (postCheck) {
+          postCheck(relationTuple, isPermitted);
         }
         if (!isPermitted) {
           throw unauthorizedFactory(
             context,
-            new Error(`Unauthorized access for ${relationTuple}`)
+            new Error(`Unauthorized access for ${relationTuple.toString()}`)
           );
         }
       }

diff --git a/packages/keto-client-wrapper/test/keto-client-wrapper.spec.ts b/packages/keto-client-wrapper/test/keto-client-wrapper.spec.ts
@@ -111,8 +111,7 @@ describe('Keto client wrapper E2E', () => {
         'x-current-user-id': subjectObject,
       });
     expect(body).toEqual({
-      error: 'Forbidden',
-      message: 'Forbidden resource',
+      message: 'Forbidden',
       statusCode: 403,
     });
   });

diff --git a/packages/kratos-client-wrapper/src/lib/ory-authentication.guard.ts b/packages/kratos-client-wrapper/src/lib/ory-authentication.guard.ts
@@ -31,8 +31,8 @@ const defaultOptions: OryAuthenticationGuardOptions = {
       .getRequest()
       ?.headers?.authorization?.replace('Bearer ', ''),
   cookieResolver: (ctx) => ctx.switchToHttp().getRequest()?.headers?.cookie,
-  unauthorizedFactory(ctx, error) {
-    return new UnauthorizedException(error);
+  unauthorizedFactory() {
+    return new UnauthorizedException();
   },
 };
 

diff --git a/packages/kratos-client-wrapper/test/kratos-client-wrapper.spec.ts b/packages/kratos-client-wrapper/test/kratos-client-wrapper.spec.ts
@@ -132,9 +132,8 @@ describe('Kratos client wrapper E2E', () => {
         Authorization: `Bearer ory_st_${randomBytes(8).toString('hex')}`,
       });
     expect(body).toEqual({
-      error: 'Forbidden',
-      message: 'Forbidden resource',
-      statusCode: 403,
+      message: 'Unauthorized',
+      statusCode: 401,
     });
   });
 });