fix(thresholds): Fix updating plan with deleted thresholds #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61136d0 to
55af7b9
Compare
nudded
approved these changes
Aug 26, 2024
b406d18 to
0fc75f0
Compare
0fc75f0 to
710656a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We were getting validation erros when updating a plan via the UI.
The problem was a specific combination of: removing and re-adding thresholds with the same amount because of a constraint. First we were creating a new threshold while the old one (with the same amount was still in the DB). Also there might have been the same threshold wtih that amount existing but soft deleted.
Description
Refactor the validations, and saving logic of thresholds.