feat(webhook): Always dispatch webhook job #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd4684b to
22f437e
Compare
22f437e to
30b6430
Compare
abdussamadbello
pushed a commit
to abdussamadbello/lago-api
that referenced
this pull request
Aug 8, 2024
## Description Currently, we often make a query to the DB to figure if we should enqueue a job to send the webhooks. As discussed during our tech meeting about a month ago, we're moving to always enqueuing a job. The job will simply do nothing if there is no webhook_endpoint configured for the given organization. It doesn't show in the the diff but the orgs without endpoints won't receive any webhook. https://github.com/getlago/lago-api/blob/b615f63a405efe81990436667f99c6ee34b408e6/app/services/webhooks/base_service.rb#L24-L27 ### Benefits * Centralized logic of _"should we send webhook?"_ in the job (easier if want to [subscribe to only a subset of webhooks](getlago#1993)) * Saves a query during the main tasks ### Down sides * Enqueues more jobs (very small jobs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we often make a query to the DB to figure if we should enqueue a job to send the webhooks.
As discussed during our tech meeting about a month ago, we're moving to always enqueuing a job. The job will simply do nothing if there is no webhook_endpoint configured for the given organization.
It doesn't show in the the diff but the orgs without endpoints won't receive any webhook.
lago-api/app/services/webhooks/base_service.rb
Lines 24 to 27 in b615f63
Benefits
Down sides