Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integrations): Address customer QA returns #2042

Merged
merged 1 commit into from
May 20, 2024
Merged

fix(integrations): Address customer QA returns #2042

merged 1 commit into from
May 20, 2024

Conversation

ivannovosad
Copy link
Contributor

Roadmap Task

👉 https://getlago.canny.io/feature-requests/p/integration-with-netsuite

Context

Currently Lago does not support accounting integrations

Description

This PR fixes multiple issue we found during the QA:

  • Missing integration_customers in the customer serializer
  • Integration customer update was not called
  • script_endpoint_url should be mandatory

@ivannovosad ivannovosad force-pushed the int-customers-qa-returns branch from 2d0b07e to 082c5fe Compare May 20, 2024 10:39
@ivannovosad ivannovosad force-pushed the int-customers-qa-returns branch from 082c5fe to b6ed534 Compare May 20, 2024 11:31
@ivannovosad ivannovosad merged commit d9ff1a8 into main May 20, 2024
6 checks passed
@ivannovosad ivannovosad deleted the int-customers-qa-returns branch May 20, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovrocolic lovrocolic lovrocolic approved these changes

@vincent-pochet vincent-pochet Awaiting requested review from vincent-pochet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivannovosad @lovrocolic