Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gql): Add admin_count custom metadata for organization members #2039

Merged
merged 4 commits into from
May 21, 2024

Conversation

julienbourdeau
Copy link
Contributor

@julienbourdeau julienbourdeau commented May 20, 2024

Context

Granular permissions are being added to Lago.

Description

In the frontend, we need to know how many admins there are currently on the app. We're adding a new custom attribute to the pagination metadata 😎
https://github.com/RenoFi/graphql-pagination?tab=readme-ov-file#custom-metadata

The backend is also updated so it won't let you delete the last admin anyway.

@julienbourdeau julienbourdeau requested a review from ansmonjol May 20, 2024 09:25
@julienbourdeau julienbourdeau force-pushed the feat/gql-admin-count-metadata branch 2 times, most recently from bdc789f to 1d3fed4 Compare May 20, 2024 11:59
@julienbourdeau julienbourdeau force-pushed the feat/gql-admin-count-metadata branch from 1d3fed4 to 34076a4 Compare May 20, 2024 15:14
@julienbourdeau julienbourdeau merged commit b0d2dd7 into main May 21, 2024
6 checks passed
@julienbourdeau julienbourdeau deleted the feat/gql-admin-count-metadata branch May 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants