feat(pdf): Use img tag for Lago logo in invoices
#2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9b19e42 to
a256425
Compare
img tag for Lago logo in invoices
a256425 to
7622df9
Compare
7622df9 to
68b9fae
Compare
julienbourdeau
commented
May 30, 2024
rsempe
reviewed
May 30, 2024
34ee5e5 to
cad1c60
Compare
rsempe
approved these changes
May 30, 2024
|
Here is an invoice PDF created on staging.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users complained that the logo didn't show up in the PDF so we're experiementing a way to use
imgin the PDF template instead ofsvgdirectly.https://gotenberg.dev/docs/routes#html-file-into-pdf-route