-
Notifications
You must be signed in to change notification settings - Fork 106
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(dunning): Add payment_request.payment_failure webhook (#2501)
## Roadmap Task 👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices ## Context We want to be able to manually request payment of the overdue balance and send emails for reminders. ## Description The goal of this change is to add the missing payment request payment failure webhook.
- Loading branch information
Showing
7 changed files
with
134 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
app/serializers/v1/payment_providers/payment_request_payment_error_serializer.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# frozen_string_literal: true | ||
|
||
module V1 | ||
module PaymentProviders | ||
class PaymentRequestPaymentErrorSerializer < ModelSerializer | ||
alias_method :payment_request, :model | ||
|
||
def serialize | ||
{ | ||
lago_payment_request_id: payment_request.id, | ||
lago_invoice_ids: payment_request.invoice_ids, | ||
lago_customer_id: payment_request.customer.id, | ||
external_customer_id: payment_request.customer.external_id, | ||
provider_customer_id: options[:provider_customer_id], | ||
payment_provider: payment_request.customer.payment_provider, | ||
payment_provider_code: payment_request.customer.payment_provider_code, | ||
provider_error: options[:provider_error] | ||
} | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
app/services/webhooks/payment_providers/payment_request_payment_failure_service.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# frozen_string_literal: true | ||
|
||
module Webhooks | ||
module PaymentProviders | ||
class PaymentRequestPaymentFailureService < Webhooks::BaseService | ||
private | ||
|
||
def current_organization | ||
@current_organization ||= object.organization | ||
end | ||
|
||
def object_serializer | ||
::V1::PaymentProviders::PaymentRequestPaymentErrorSerializer.new( | ||
object, | ||
root_name: object_type, | ||
provider_error: options[:provider_error], | ||
provider_customer_id: options[:provider_customer_id] | ||
) | ||
end | ||
|
||
def webhook_type | ||
"payment_request.payment_failure" | ||
end | ||
|
||
def object_type | ||
"payment_provider_payment_request_payment_error" | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
spec/serializers/v1/payment_providers/payment_request_payment_error_serializer_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# frozen_string_literal: true | ||
|
||
require "rails_helper" | ||
|
||
RSpec.describe ::V1::PaymentProviders::PaymentRequestPaymentErrorSerializer do | ||
subject(:serializer) { described_class.new(payment_request, options) } | ||
|
||
let(:payment_request) { create(:payment_request, organization:, customer:, invoices: [invoice]) } | ||
let(:invoice) { create(:invoice, customer:, organization:) } | ||
let(:customer) { create(:customer, organization:) } | ||
let(:organization) { create(:organization) } | ||
let(:options) do | ||
{ | ||
"provider_customer_id" => "customer", | ||
"provider_error" => { | ||
"error_message" => "message", | ||
"error_code" => "code" | ||
} | ||
}.with_indifferent_access | ||
end | ||
|
||
it "serializes the object" do | ||
result = JSON.parse(serializer.to_json) | ||
|
||
aggregate_failures do | ||
expect(result["data"]["lago_payment_request_id"]).to eq(payment_request.id) | ||
expect(result["data"]["lago_invoice_ids"]).to eq([invoice.id]) | ||
expect(result["data"]["lago_customer_id"]).to eq(customer.id) | ||
expect(result["data"]["external_customer_id"]).to eq(customer.external_id) | ||
expect(result["data"]["provider_customer_id"]).to eq(options[:provider_customer_id]) | ||
expect(result["data"]["payment_provider"]).to eq(customer.payment_provider) | ||
expect(result["data"]["payment_provider_code"]).to eq(customer.payment_provider_code) | ||
expect(result["data"]["provider_error"]).to eq(options[:provider_error]) | ||
end | ||
end | ||
end |
16 changes: 16 additions & 0 deletions
16
spec/services/webhooks/payment_providers/payment_request_payment_failure_service_spec.rb
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# frozen_string_literal: true | ||
|
||
require "rails_helper" | ||
|
||
RSpec.describe Webhooks::PaymentProviders::PaymentRequestPaymentFailureService do | ||
subject(:webhook_service) { described_class.new(object: payment_request, options: webhook_options) } | ||
|
||
let(:payment_request) { create(:payment_request, organization:, customer:) } | ||
let(:customer) { create(:customer, organization:) } | ||
let(:organization) { create(:organization) } | ||
let(:webhook_options) { {provider_error: {message: "message", error_code: "code"}} } | ||
|
||
describe ".call" do | ||
it_behaves_like "creates webhook", "payment_request.payment_failure", "payment_provider_payment_request_payment_error" | ||
end | ||
end |