fix (integration-customers): adapt integration customer queries (#2269)

## Context Improve integration customer queries ## Description Currently Accounting integrations, Netsuite and Xero, are supported in Lago but tax integration Anrok is currently being implemented. This PR improves existing integration customers queries. Customer can have attached ONLY one accounting integration and ONLY one tax integration, but we want to avoid case that tax integration customer is returned in accounting context.
getlago · Jul 10, 2024 · 44ccecb · 44ccecb
1 parent 7cf858a
commit 44ccecb
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 7 deletions.
diff --git a/app/graphql/types/credit_notes/object.rb b/app/graphql/types/credit_notes/object.rb
@@ -58,7 +58,7 @@ def integration_syncable
       end
 
       def external_integration_id
-        integration_customer = object.customer&.integration_customers&.first
+        integration_customer = object.customer&.integration_customers&.accounting_kind&.first
 
         return nil unless integration_customer
 

diff --git a/app/graphql/types/invoices/object.rb b/app/graphql/types/invoices/object.rb
@@ -66,7 +66,7 @@ def integration_syncable
       end
 
       def external_integration_id
-        integration_customer = object.customer&.integration_customers&.first
+        integration_customer = object.customer&.integration_customers&.accounting_kind&.first
 
         return nil unless integration_customer
 

diff --git a/app/models/credit_note.rb b/app/models/credit_note.rb
@@ -106,7 +106,7 @@ def add_on_items
   end
 
   def should_sync_credit_note?
-    finalized? && customer.integration_customers.any? { |c| c.integration.sync_credit_notes }
+    finalized? && customer.integration_customers.accounting_kind.any? { |c| c.integration.sync_credit_notes }
   end
 
   def voidable?

diff --git a/app/models/integration_customers/base_customer.rb b/app/models/integration_customers/base_customer.rb
@@ -12,6 +12,10 @@ class BaseCustomer < ApplicationRecord
 
     validates :customer_id, uniqueness: {scope: :type}
 
+    scope :accounting_kind, -> do
+      where(type: %w[IntegrationCustomers::NetsuiteCustomer IntegrationCustomers::XeroCustomer])
+    end
+
     settings_accessors :sync_with_provider
 
     def self.customer_type(type)

diff --git a/app/models/invoice.rb b/app/models/invoice.rb
@@ -279,11 +279,11 @@ def mark_as_dispute_lost!(timestamp = Time.current)
   end
 
   def should_sync_invoice?
-    finalized? && customer.integration_customers.any? { |c| c.integration.sync_invoices }
+    finalized? && customer.integration_customers.accounting_kind.any? { |c| c.integration.sync_invoices }
   end
 
   def should_sync_sales_order?
-    finalized? && customer.integration_customers.any? { |c| c.integration.sync_sales_orders }
+    finalized? && customer.integration_customers.accounting_kind.any? { |c| c.integration.sync_sales_orders }
   end
 
   private

diff --git a/app/models/payment.rb b/app/models/payment.rb
@@ -13,6 +13,6 @@ class Payment < ApplicationRecord
   delegate :customer, to: :invoice
 
   def should_sync_payment?
-    invoice.finalized? && customer.integration_customers.any? { |c| c.integration.sync_payments }
+    invoice.finalized? && customer.integration_customers.accounting_kind.any? { |c| c.integration.sync_payments }
   end
 end
diff --git a/app/services/integrations/aggregator/invoices/base_service.rb b/app/services/integrations/aggregator/invoices/base_service.rb
@@ -31,7 +31,7 @@ def integration
         end
 
         def integration_customer
-          @integration_customer ||= customer&.integration_customers&.first
+          @integration_customer ||= customer&.integration_customers&.accounting_kind&.first
         end
 
         def payload(type)