Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi3filter: fix array of primitives query parameter types #921

Merged
merged 4 commits into from
Mar 9, 2024
Merged

openapi3filter: fix array of primitives query parameter types #921

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25c2ce4
fix array of primitives query parameter types
danicc097 Mar 9, 2024
893830e
update tests
danicc097 Mar 9, 2024
903caa1
fix parameter checks
danicc097 Mar 9, 2024
aa2ca92
add test cases
danicc097 Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test cases
  • Loading branch information
@danicc097
danicc097 committed Mar 9, 2024
commit aa2ca922ded6868c20253b6eda3e2d7e6ee6a1e1
26 changes: 26 additions & 0 deletions openapi3filter/validation_error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,32 @@ func getValidationTests(t *testing.T) []*validationTest {
Title: "parameter \"deepFilter\" in query is invalid: notbool is an invalid boolean",
},
},
{
name: "error - incorrect deepobject query parameter type integer",
args: validationArgs{
r: newPetstoreRequest(t, http.MethodGet, "/pet/filter?deepFilter[integers]=1.234", nil),
},
wantErrParam: "deepFilter",
wantErrBody: `parameter "deepFilter" in query has an error: path integers: value 1.234: an invalid integer: invalid syntax`,
wantErrParamIn: "query",
wantErrResponse: &ValidationError{
Status: http.StatusBadRequest,
Title: "parameter \"deepFilter\" in query is invalid: 1.234 is an invalid integer",
},
},
{
name: "error - incorrect deepobject query parameter type integer",
args: validationArgs{
r: newPetstoreRequest(t, http.MethodGet, "/pet/filter?deepFilter[numbers]=aaa", nil),
},
wantErrParam: "deepFilter",
wantErrBody: `parameter "deepFilter" in query has an error: path numbers: value aaa: an invalid number: invalid syntax`,
wantErrParamIn: "query",
wantErrResponse: &ValidationError{
Status: http.StatusBadRequest,
Title: "parameter \"deepFilter\" in query is invalid: aaa is an invalid number",
},
},
{
name: "error - missing required query string parameter",
args: validationArgs{
Expand Down
Loading