Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openapi3: handle refs missing fragment #511

Merged
merged 1 commit into from
Nov 26, 2023
Merged

openapi3: handle refs missing fragment #511

merged 1 commit into from
Nov 26, 2023

Conversation

fenollp
Copy link
Collaborator

@fenollp fenollp commented Mar 16, 2022 •
edited
Loading

Stricto sensu the issue is twofold

  1. error message is misleading and hides the actual error
  2. schema draft04 deserialization is incorrect in that a # ref under definitions being dereferenced leads to a "bad data" error, wrongly.

So far only (1) has been addressed.

@fenollp fenollp force-pushed the issue495 branch 6 times, most recently from baea0c9 to 22a6c33 Compare November 26, 2023 15:50
@fenollp
openapi3: handle refs missing fragment
ac3e637 
* fixes getkin#495
* superseeds getkin#867

Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
@fenollp fenollp changed the title reproduce and explore #495 openapi3: handle refs missing fragment Nov 26, 2023
@fenollp fenollp marked this pull request as ready for review November 26, 2023 16:13
@fenollp fenollp merged commit 582e6d0 into getkin:master Nov 26, 2023
7 checks passed
@fenollp fenollp deleted the issue495 branch November 26, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing error when validating certain external ref
1 participant
@fenollp