Instantiate parent in Page->translatedLanguages()

[OleVik]

Fixes #2163.

[mahagr]

A similar fix is probably needed for Flex Pages.

[mahagr]

@OleVik There's a small issue there; parent isn't the correct one as it comes from the current language, not from the same language as the page.

[OleVik]

@mahagr I added a check for a translated version of the parent, in the same language as the current Page, and set the parent's route to reflect that. I also updated the returned route to include the language-prefix, otherwise all languages return the same route.

[mahagr]

It still won't work as you can change slug from the parent based on the language. So the URL is basically going to be wrong: /en/dogs/intro -> /fi/koirat/esittely. With your change, the resulting URL would be: /fi/dogs/esittely which is still wrong.

The only way to get it right, is to go up on a tree and initialize all the translated parent pages and get route from them.

[OleVik]

That's derived from aliases, right? Wouldn't the router then apply /fi/koirat/esittely if /fi/dogs/intro was requested? I'm trying to avoid recursion upwards, assigning new routes along the way, if possible - to not impact performance as much.

[mahagr]

I think the best thing though, would be to get the rawRoute() instead of trying trying to build translated parent route (it won't work with your code). If you use rawRoute(), it will never be translated (it uses folders in the filesystem to name the route) and that route is always added to the router and known to work.

The issue with your approach is that it'll not build the nested route right way causing 404 in many cases as the route cannot be found.

[mahagr]

@OleVik I checked this and, unfortunately no, your suggestion won't work like that as Grav currently keeps record only from the current translation. This means that all the other slugs are coming from the wrong language.

[OleVik]

What associates /en/dogs/intro with /fi/koirat/esittely though? Seemingly the slug, per Multi-Language Routing. I probably need to expand my test-case, I initially just needed a fix for $this->grav['page']->translatedLanguages(true) - which just returns empty values right now.

My assumption about the aliases stemmed from Language Alias Routes, which with rawRoute() is supposed to process the page accordingly - from /fi/dogs/intro yielding /fi/koirat/esittely.

[rhukster]

Each language, no matter the language specific slugs, are associated by Lang and raw route.

[OleVik]

But do they then belong to different folders, or does the Page FrontMatter just declare the translation? I haven't really had need to use multi-language that much in Grav before, so my test-cases were always rather simple.