Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add new page #54

Closed
dimayakovlev opened this issue Aug 12, 2015 · 26 comments
Closed

Cannot add new page #54

dimayakovlev opened this issue Aug 12, 2015 · 26 comments
Labels

Comments

@dimayakovlev
Copy link
Contributor

If I am trying to add a new page without parent page (parent is root):

Whoops\Exception\ErrorException thrown with message "Call to a member function path() on a non-object"
Stacktrace:
#0  in D:\OpenServer\domains\grav\user\plugins\admin\classes\admin.php:525

If I am trying to save a new page with parent:
Errors
I am using local webserver with Apache/2.2.29 (Win32) and PHP 5.4.35.

@rhukster
Copy link
Member

Not sure if this is related, but do you have param separator set to ; in your system configuration?

@rhukster rhukster added the bug label Aug 12, 2015
@reyman
Copy link

reyman commented Aug 12, 2015

same here, impossible to create a new page using root :(

@flaviocopes
Copy link
Contributor

I cannot replicate - just to make sure, is everything (grav & admin plugin) up to date?

@rhukster
Copy link
Member

I cannot reproduce either. I am able to save a new page with parent set to root.

@rhukster
Copy link
Member

@reyman are you on windows also??

@reyman
Copy link

reyman commented Aug 12, 2015

no i'm on linux

@reyman
Copy link

reyman commented Aug 12, 2015

Bug arrive not at save, but when i want to publish : 'Validation failed: Invalid input in Process'

I Create a page
I Save the page
I Change visibility
Eror

@dimayakovlev
Copy link
Contributor Author

@rhukster parameter separator is ;

@flaviocopes
Copy link
Contributor

@reyman I think this is fixed in Grav 0.9.37, you're on that?

@dimayakovlev
Copy link
Contributor Author

With Grav 0.9.37 I can create subpages without errors.

@reyman
Copy link

reyman commented Aug 12, 2015

@flaviocopes i'm on 0.9.37 and i update today the php bin/gpm selfupgrade -f

@rhukster
Copy link
Member

Just to confirm this issue you are seeing is only on root level pages? subpages are fine? What exactly are you doing when you create the page? Can you provide me step-by-step instructions on how you get this error. I need to be able to reproduce it before I can fix it.

@dimayakovlev
Copy link
Contributor Author

@rhukster Yes, after upgrade to Grav 0.9.37 I can create supbages without errors.

An error occurs only when creating root level page.

1.Сlick Add Page button
2.Fill Add Page form. Parent Page is Root
3.Click Continue button

Error:

Whoops\Exception\ErrorException thrown with message "Call to a member function path() on a non-object"

Stacktrace:
#0  in D:\OpenServer\domains\grav\user\plugins\admin\classes\admin.php:525

@rhukster
Copy link
Member

Ok, i'm going to have to ask you to test this again with Grav 0.9.38 when it's released (soon). I have reworked the admin class so the line number is not really that helpful from 0.9.37.

@rhukster
Copy link
Member

Also out of curiosity can you create it as a subpage and then move it to root?

@dimayakovlev
Copy link
Contributor Author

@rhukster Yes, moving subpage to root works fine.

@rhukster
Copy link
Member

Can you please provide me with a zip file of your user/ folder. I really need to work out if you have something special in your setup because I still can't replicate this error.

@Sommerregen
Copy link
Contributor

@rhukster I really suspect that this is again a param_sep issue - at least the error looks quite familiar for me. If I'm right I should fail creating a page on my Windows machine, too. I will try that out and leave you a message as soon as possible here.

@rhukster
Copy link
Member

I think your right, i was in the process last night of getting my windows VM running again to test it there. If you have one operational and can help debug it, that would be awesome.

@dimayakovlev
Copy link
Contributor Author

@rhukster Here it is http://1drv.ms/1E03bih

@Sommerregen
Copy link
Contributor

@rhukster I just tested on Apache/2.4.7 (Win7) PHP/5.4.25 with param_sep: + (but it shouldn't make any difference) with the latest develop branch and creating pages is possible. However I will try to figure it out. Maybe there are some remnants, which are not param_sep compliant.

Maybe this bug was fixed in the develop branch, soon after Admin v0.3.0 has been released...

UPDATE: I reviewed the admin plugin and have found some minor bugs related to the param_sep: + option (one was related with the backups and one with forgotten password see commit).

@rhukster
Copy link
Member

Are you going to submit a PR based on your fork with those minor fixes?

@Sommerregen
Copy link
Contributor

Yes, I will do it. I just have had no time to look at it and see, if I have not overlooked anything. I will submit one this evening!

@rhukster
Copy link
Member

Just saw another instance of this error:

grav_page_error

Looks like this one is with Ammps and grav is in it's own subdirectory.

@Sommerregen
Copy link
Contributor

Ok, just prepared a PR for you ;-) Concerning your error report, I have another minor issue (not really important) and happens when I try to point my browser to an unknown path (see the address bar):

error

@rhukster
Copy link
Member

Should be fixed! Please create new issues for any other windows bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants