Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force user session expiration after logout #36

Closed
Sommerregen opened this issue Aug 7, 2015 · 3 comments
Closed

Force user session expiration after logout #36

Sommerregen opened this issue Aug 7, 2015 · 3 comments

Comments

@Sommerregen
Copy link
Contributor

When logging out, the session for the current user have to be closed and any credentials deleted. Currently this is not the case.

@rhukster
Copy link
Member

rhukster commented Aug 7, 2015

Umm.. should be the case, the session is invalidated and restarted.

https://github.com/getgrav/grav-plugin-login/blob/develop/classes/controller.php#L114-L120

@rhukster
Copy link
Member

rhukster commented Aug 8, 2015

I just tested this and the session is reset on logout. A new session is started, but it's a new session.

@rhukster rhukster closed this as completed Aug 8, 2015
@Sommerregen
Copy link
Contributor Author

Good catch! But... sorry to reopen it 😋

I found the issue. This is issue is closely connected with issue #30. It is due to different setting of config.system.param_sep. In my case it was config.system.param_sep: '+', which (as you know) is necessary for Windows... Actually I just have to replace all task: to task{{ config.system.param_sep }} in the Twig files.

See my PR #35, which also adds a logout page, since even though you are destroying and re-creating a new session in the above lines, the logout message will not be printed to the user after the redirect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants