Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Media single file "View" action doesn't work for most files #1727

Closed
robertbak opened this issue Jul 31, 2019 · 0 comments
Closed

Page Media single file "View" action doesn't work for most files #1727

robertbak opened this issue Jul 31, 2019 · 0 comments
Assignees

Comments

@robertbak
Copy link

The button works for image files (since they have "extras" filled), but doesn't work for most other file types (null/undefined instead of the filename is inserted into the url).

This was introduced in dbdd6e2 and as far as I can tell there's no reason for the change.

Steps to reproduce:

  1. Drop an mp4 or pdf file into page media
  2. Save
  3. Try using the view button

Result:
Page url with undefined instead of the file name is opened

Expected:
Open the file in a new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants