Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a rabbitmq to finalize pending payments #370

Merged
merged 22 commits into from
May 30, 2023

Conversation

LucasRouckhout
Copy link
Contributor

@LucasRouckhout LucasRouckhout commented May 29, 2023

Fixes #369

@LucasRouckhout LucasRouckhout added the enhancement New feature or request label May 29, 2023
@LucasRouckhout LucasRouckhout self-assigned this May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Merging #370 (9db249a) into main (e89d6c2) will increase coverage by 4.85%.
The diff coverage is 61.44%.

❗ Current head 9db249a differs from pull request most recent head 8c01655. Consider uploading reports for the commit 8c01655 to get more accurate results

@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
+ Coverage   55.18%   60.03%   +4.85%     
==========================================
  Files          52       50       -2     
  Lines        3251     3213      -38     
==========================================
+ Hits         1794     1929     +135     
+ Misses       1263     1078     -185     
- Partials      194      206      +12     
Impacted Files Coverage Δ
lib/service/config.go 0.00% <ø> (ø)
lib/service/invoices.go 70.55% <0.00%> (-0.21%) ⬇️
integration_tests/util.go 86.82% <50.00%> (-1.18%) ⬇️
rabbitmq/amqp.go 58.01% <58.01%> (ø)
rabbitmq/rabbitmq.go 55.77% <59.63%> (-8.03%) ⬇️
rabbitmq/mock_rabbitmq/rabbitmq.go 67.85% <67.85%> (ø)
lib/service/checkpayments.go 57.14% <78.57%> (+1.58%) ⬆️

... and 4 files with indirect coverage changes

@LucasRouckhout LucasRouckhout marked this pull request as ready for review May 30, 2023 09:02
@kiwiidb kiwiidb self-requested a review May 30, 2023 09:21
Copy link
Contributor

@kiwiidb kiwiidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise lgtm

@kiwiidb kiwiidb self-requested a review May 30, 2023 09:54
@kiwiidb kiwiidb merged commit 2d40875 into main May 30, 2023
@kiwiidb kiwiidb deleted the feature/rabbitmq-payment-finalize branch May 30, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update missing pending payments from rabbitmq
2 participants