Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent EOF loop #348

Merged
merged 2 commits into from
Apr 13, 2023
Merged

prevent EOF loop #348

merged 2 commits into from
Apr 13, 2023

Conversation

kiwiidb
Copy link
Contributor

@kiwiidb kiwiidb commented Apr 7, 2023

Fixes #345
In case the connection to RabbitMQ is lost due to networking error or RabbitMQ being down, the channel will be closed and lndhub should be restarted to try and reconnect again.

@kiwiidb kiwiidb requested a review from LucasRouckhout April 7, 2023 13:06
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #348 (e167940) into main (c7f2d85) will decrease coverage by 0.07%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
- Coverage   54.19%   54.12%   -0.07%     
==========================================
  Files          50       50              
  Lines        3096     3100       +4     
==========================================
  Hits         1678     1678              
- Misses       1236     1239       +3     
- Partials      182      183       +1     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
rabbitmq/rabbitmq.go 63.80% <25.00%> (-0.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kiwiidb kiwiidb merged commit 099f63a into main Apr 13, 2023
@kiwiidb kiwiidb deleted the fix/rabbit-connection branch April 13, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on Rabbit channel close
1 participant