conditionally restart connection after refetch or reauth #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ae2c106 to
ecbbaec
Compare
erquhart
commented
Jan 23, 2025
| @@ -301,7 +307,9 @@ export class AuthenticationManager { | |||
| this._logVerbose( | |||
| "resuming WS after auth token fetch (if currently paused)", | |||
| ); | |||
| this.resumeSocket(); | |||
There was a problem hiding this comment.
This isn't removed, it's relocated to the only place where the socket is paused. Every other resume call here (which is every other call after initialization) doesn't do anything.
c77f65b to
4a406d1
Compare
4a406d1 to
b16a044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
resumeSocket()out ofrefetchToken()and intosetConfig(), which is the only place a pause is initiated. This clarifies where this call actually needs to occur.refetchToken()ortryToReauthenticate(), if the connection is stopped, restart it. Because it's possible for these two functions to run before or after one another for multiple reasons, this ensures a connection doesn't remain stopped after a potentially successful reauth.restartSocket()to no longer throw if attempted on an unstopped connection, similar to how resume works. Restart is only attempted byrefetchToken()andtryToReauthenticate(), and there's no guarantee whether the connection will be stopped or not.