add more verbose logs for auth #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d97e74 to
2dec0b0
Compare
erquhart
commented
Jan 23, 2025
| newAuth.state === "waitingForServerConfirmationOfFreshToken" | ||
| ? { | ||
| ...newAuth, | ||
| token: newAuth.token.slice(0, 7) + "..." + newAuth.token.slice(-7), |
There was a problem hiding this comment.
This is meant to help clarify which token is being used. I don't believe showing the first and last 7 characters of the jwt will present a security risk, but wanted to call this out in case it does. We also may just need the last 7. This is also done in one other place in the PR for comparison.
2dec0b0 to
ac8a03a
Compare
ac8a03a to
2a6404d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some verbose logs that were useful for me, but they may reveal more internal details than desired. Feel free to close or request changes.