Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : Add Shapes drawing, Floating Calling toolbar, Smoothing #83

Closed
wants to merge 3 commits into from

Conversation

pubpub-zz
Copy link

New feature : Rectangle / Ellipse / Line / Arrow drawing added
Stroke smoothing added
Adding also the floating window for calling Gink
resolves #78, resolves #73, resolves #47, resolves #16,
I Have not added new feature into the ReadMe.

Add a floating icon that can open the toolbar / drawing panel, can be disabled if top is set to -1 in config.ini
Smooth drawings
Add Line,Rectangle,Ellipse, and Arrows drawing capabilities
@geovens
Copy link
Owner

geovens commented Jun 16, 2020

Hi pubpub-zz,

I really appreciate your contribution. I think that the tools you added (free-ink, line, square etc.) working as a second parameter to the pen attributes (color, width) is a very interesting idea. But as i may have expressed before, I hope to keep this software simple, even though I regret it could not provide line/arrow/square tools that many ask for. Adding these tools will cause significant change in the base structure of the code as well as user interaction interface design, and this will not only induce too much future effort to maintain the stability of this software, but also defy the aim of simplicity of this software.

I tried your build and it seems to be too buggy. For example, sometimes the line jumps out of screen when I releases mouse button; the pan tool and the mouse pointer tool is totally broken; and when I click the eraser tool the software crashes. I think that this could be a proof that adding these tools is a very difficult work. Even if you are able to fix them all, still the trade-off between the tools added and the user interface complication added may not be worth it in my view.

@pubpub-zz
Copy link
Author

Hi Geovens,
thanks for your feedback. I will keep my fork open. if somebody is interested in. I will have a look at the bugs You've identified. I'm currently trying to add string and tag numbering. Do not hesitate to contact me if I can help you.

@pubpub-zz pubpub-zz closed this Jun 17, 2020
@pubpub-zz
Copy link
Author

extra notes, I've normally fixed the issues raised by geovens on my branch with new features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants