Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use suspense for plotly #6622

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Conversation

offtherailz
Copy link
Member

Description

In order to optimize the bundle size, dynamically loading plotly js lib on demand improves the bundle size of ~1MB of 12 total.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#4297

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz self-assigned this Mar 9, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 81.121% when pulling 2f126be on offtherailz:split_plotlyjs into 6c372a1 on geosolutions-it:master.

@offtherailz offtherailz added this to the 2021.02.00 milestone Mar 11, 2021
@offtherailz offtherailz merged commit c020902 into geosolutions-it:master Mar 11, 2021
agpenton pushed a commit to agpenton/MapStore2 that referenced this pull request Jul 8, 2021
agpenton pushed a commit to agpenton/MapStore2 that referenced this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants