Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5561: Add documentation for all plugins #6084

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Oct 22, 2020

Description

All the missing plugins has been documented and added to the main docma-config. Also all the missing pages are documented.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe: Documentation

link to doc can not be provided because JSDoc is hosted on mapstore. To check it run npm run doctest and npm start

Issue

What is the current behavior?

#5561

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

Note: at the moment the context creator links to mapstore.geo-solutions.it, and this doc is instead deployed on dev.

@offtherailz offtherailz added this to the 2020.03.00 milestone Oct 22, 2020
@offtherailz offtherailz self-assigned this Oct 22, 2020
@coveralls
Copy link

coveralls commented Oct 22, 2020

Coverage Status

Coverage decreased (-0.008%) to 83.069% when pulling 362fe1f on offtherailz:doc_plugins into 884d091 on geosolutions-it:master.

@offtherailz offtherailz reopened this Oct 22, 2020
@offtherailz offtherailz requested a review from MV88 October 23, 2020 09:44
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments:

  • i think pages should have their own section, maybe a link below plugins
    image

  • we need to rename this plugin with createnewContent
    image

  • can you add "EPSG:3003" to filterAllowedCRS in CRS selector plugin ?

  • found this at the end of plugins

image

* Menu button that can contain other plugins entries.
* Usually rendered inside {@link #plugins.OmniBar|plugins.OmniBar}
* You can render an item inside burger menu by adding the following to the `containers` entry of your plugin.
* It is a wrapper for `ToolsContainer` so all the properties of the tools of {@ plugins.containers.ToolContainer|ToolContainer} can be used here (action, selector ...).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong link{@ plugins.containers.ToolContainer|ToolContainer}
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in toolContainer can we move the examples below ?
image

Co-authored-by: Matteo V. <matteo.velludini.geosolutions@gmail.com>
@offtherailz
Copy link
Member Author

offtherailz commented Oct 23, 2020

@MV88 thank you very much for your comments, they are very useful.
#6084 (review)
about this comment, I linked it in a document that we can use to reorganize plugins that I already wrote. We can do it in that task
The scope of this issue is to document each plugin/page

@offtherailz offtherailz requested a review from MV88 October 26, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants