Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6024: Retain geometry on deselect #6028

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Oct 14, 2020

Description

This PR address the feature not retaining issue on deselecting the geometry and restricting unnecessary the geometry highlight event

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#6024

What is the new behavior?

  • Upon making changes to a feature, deselecting the feature will retain all the changes made to a feature
  • On adding a new geometry, the geometry highlight call is restricted until the drawing is complete and the feature is valid

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 83.139% when pulling 6a1134f on dsuren1:6024_save_deselect into 79c8533 on geosolutions-it:master.

@dsuren1 dsuren1 changed the title #6024: Auto save geometry on deselect #6024: Retain geometry on deselect Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants