Fixes #552 Handle properly the new props #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| isNearlyEqual(newCenter.y, currentCenter.y); | ||
| // if props are the same nothing to do, otherwise | ||
| // we need to check if the new center is equal to map center | ||
| const centerIsUpdate = propsCentersEqual || |
There was a problem hiding this comment.
constant/variable names are important: this should be called centerIsNotUpdated
665096a to
c9cd539
Compare
|
Updated. Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were testing new props against the map values instead of the current props. I update the way we test the new props by checking against the current props and the map values. This pull request also ads a proper test for this.