Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4732 Fix MapFooter update issue #4733

Merged

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Jan 16, 2020

Description

The issue #4732 was due to a shouldComponentUpdate that always return false. This to prevent attribution and scalebar to disappear.

The solutions proposed keeps the divs to restore them after re-mount, because it's impossible to avoid re-mount.

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?
#4732

What is the new behavior?
Now a context with optional plugins in footer will update immedialy, when user switches them in user extensions plugins (need to be merged yet)

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

--> we need to update localConfig.json in dependent projects.

Other useful information

Probably old context will not render attribution well

@offtherailz offtherailz requested a review from mbarto January 16, 2020 16:32
@offtherailz offtherailz self-assigned this Jan 16, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 84.511% when pulling 5fa7861 on offtherailz:fix_footer_pluggability into 9db5b72 on geosolutions-it:master.

@offtherailz offtherailz merged commit 06e1489 into geosolutions-it:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants