Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4716. Fixed issues with map details and thumbnail creation in home page #4726

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Jan 15, 2020

Description

Removed unnecessary and remaining double encoding due to the new API entry (PUT with Body, instead of URL encoded value, see #4673).
These caused an effective double encoding of the real respources (previously one encoding was removed by decoding by geostore, but the new API use a JSON as body, so no encoding is necessary anymore) and this made impossible to decode on a second load (only one decodeURIComponent is present, for retro-compatibility, but URLs was encoded 2 times in error.)

NOTE: didn't add unit tests because these where not covered and this part will be replaced soon with the Resource Observable. (see #2908)

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?
#4716 comment (thumbnails and details created in home page for maps are not available anymore after refresh)

What is the new behavior?
Thumb and detail card URLs are saved correctly (no double encoding anymore). Decoding is still present for retro-compatibility.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz requested a review from mbarto January 15, 2020 14:06
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 84.52% when pulling b2a7cfe on offtherailz:fix_4716_maps into 5147c4b on geosolutions-it:master.

@MV88 MV88 changed the title #4716. Fixed issues with map details and thubmnail creation in home page #4716. Fixed issues with map details and thumbnail creation in home page Jan 16, 2020
@tdipisa tdipisa added this to the 2020.01.01 milestone Jan 16, 2020
@tdipisa tdipisa merged commit 4a5a19b into geosolutions-it:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants