-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4720 - #4719 User Extensions - TOC plugins #4723
Merged
offtherailz
merged 13 commits into
geosolutions-it:master
from
offtherailz:user_extensions
Jan 17, 2020
Merged
#4720 - #4719 User Extensions - TOC plugins #4723
offtherailz
merged 13 commits into
geosolutions-it:master
from
offtherailz:user_extensions
Jan 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a first version of minimal User Extensions plugin with some changes on the TOC
FilterLayer
(for query panel), plugins as well as the others and modifyTOC
to be also aPluginContainer
that receives the buttons for that functionalities. The existingAddGroup
,FeatureGrid
andLayerSettings
should render a button as wellNote: To avoid a refactor the toolbar buttons code is still in the TOC and the plugins as items don't render anything, simply enable/disable the button in the TOC. @mbarto what do you think? we should move the button renderings to the items at this stage ?
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information