Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4720 - #4719 User Extensions - TOC plugins #4723

Merged
merged 13 commits into from
Jan 17, 2020

Conversation

offtherailz
Copy link
Member

@offtherailz offtherailz commented Jan 15, 2020

Description

Created a first version of minimal User Extensions plugin with some changes on the TOC

  • FilterLayer (for query panel), plugins as well as the others and modify TOC to be also a PluginContainer that receives the buttons for that functionalities. The existing AddGroup, FeatureGrid and LayerSettings should render a button as well
    Note: To avoid a refactor the toolbar buttons code is still in the TOC and the plugins as items don't render anything, simply enable/disable the button in the TOC. @mbarto what do you think? we should move the button renderings to the items at this stage ?

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz requested a review from mbarto January 15, 2020 09:51
@coveralls
Copy link

coveralls commented Jan 15, 2020

Coverage Status

Coverage increased (+0.007%) to 84.524% when pulling 2f71f77 on offtherailz:user_extensions into d1e87d0 on geosolutions-it:master.

@offtherailz offtherailz merged commit 4525991 into geosolutions-it:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants