Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3548 add coordinate editor for GFI panel #3557

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Feb 21, 2019

Description

This pr add the coordinate editor in the header of GFI panel.
the flag used to show the button that trigger visibility of coord editor in the toolbar is true by default and is called "enabledCoordEditorButton"
by default the flag used to show the coordinate editor is false by default and is called "showCoordinateEditor"

image

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
you cannot perform a GetFeatureInfo for exact coordinates

What is the new behavior?
you can use a coordinate editor to search custom point

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

If you want to avoid to hidethe button in the toolbar (true by default)

{
"name": "Identify",
  "cfg": {
    "enabledCoordEditorButton": false
}

or if you do not specify the previous config and you want to show the coordinate editor (by default is false), in the initialState add

"mapInfo": {
  "enabled": true,
  "showCoordinateEditor": true
}

@MV88 MV88 self-assigned this Feb 21, 2019
@MV88 MV88 requested a review from tdipisa February 21, 2019 15:13
@tdipisa tdipisa requested review from offtherailz and removed request for tdipisa February 21, 2019 15:19
@MV88 MV88 force-pushed the 3548_coord_editor_GFI branch from 9c6fc0a to e804a0c Compare February 21, 2019 16:29
@tdipisa tdipisa requested review from mbarto and removed request for offtherailz February 22, 2019 11:02
@mbarto
Copy link
Contributor

mbarto commented Feb 22, 2019

@tdipisa @MV88 so to enter a coordinate for GFI I have to first do a GFI clicking on the map?
I would have expected a tool external to the GFI panel.

Copy link
Contributor

@mbarto mbarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You always use comma as a decimal separator in coordinates editor. You should use the right separator for the current locale (comma is used mainly in Italy)

@tdipisa
Copy link
Member

tdipisa commented Feb 22, 2019

@tdipisa @MV88 so to enter a coordinate for GFI I have to first do a GFI clicking on the map?
I would have expected a tool external to the GFI panel.

@mbarto yes, is what we agreed in the mockup

@MV88
Copy link
Contributor Author

MV88 commented Feb 22, 2019

You always use comma as a decimal separator in coordinates editor. You should use the right separator for the current locale (comma is used mainly in Italy)

@mbarto I see the dots

image

@mbarto
Copy link
Contributor

mbarto commented Feb 22, 2019

Look here:

image

@mbarto
Copy link
Contributor

mbarto commented Feb 22, 2019

@MV88 if it depends on PC locale, then it's good, my only concern was if commas where used always

@tdipisa tdipisa merged commit 4f29b24 into geosolutions-it:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GFI via coordinate input
3 participants