Crsselector plugin #3191 #3410

baloola · 2018-12-13T10:37:26Z

Description

This PR adds the possibility to select the CRS for the map.
The listed projections should be added and defined in the configuration file.
Once the user selects the new projection, the view re-render the map.

Issues

Fix Ability to create maps in a selected CRS #3191
...

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

Bugfix
Feature

What is the current behavior? (You can also link to an open issue here)
#3191

What is the new behavior?
see the discribtion

Does this PR introduce a breaking change? (check one with "x", remove the other)

Yes
No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

coveralls · 2018-12-13T10:51:15Z

Coverage decreased (-0.1%) to 80.645% when pulling acbcdbe on baloola:crs_selector into b07332f on geosolutions-it:c042_crs.

mbarto · 2018-12-13T13:11:24Z

web/client/components/mapcontrols/crsselectormenu/crsSelectormenu.jsx

+        this.props.changeInputValue(e.target.value);
+    }
+
+    focusNext = () => {


Where is this used?

mbarto · 2018-12-13T13:13:26Z

web/client/plugins/CRSSelector.jsx

+
+    render() {
+
+        var list = [];


try to use const wherever possible, let otherwise, never use var.

mbarto · 2018-12-13T13:17:31Z

web/client/plugins/CRSSelector.jsx

+            }
+        )(Selector);
+/**
+  * CRSSelector Plugin is a plugin that shows the coordinate of the mouse position in a selected crs.


Update description... I presume this has been copied from the similar control we have for MousePosition....

mbarto · 2018-12-13T13:20:14Z

web/client/components/mapcontrols/crsselectormenu/crsSelectormenu.jsx

+const PropTypes = require('prop-types');
+const { ListGroupItem, ListGroup, FormControl } = require('react-bootstrap');
+
+class CustomMenu extends React.Component {


Component name and filename should be the same, unless there is any particular reason. Also, component jsx file should start with an uppercase letter.

offtherailz

Fix as for comments

. Please configure to add projection 3003 and use this Map to reproduce errors

Some errors found Performing GetFeatureInfo in 3003
** steps to reproduce (after switch to 3003)
Switch to 3003
Click on the map
)
Result:
After some time you will see this error:

Subscriber.js:238 Uncaught TypeError: Cannot read property 'x' of null
    at geocentricFromWgs84 (datumUtils.js:236)
    at __webpack_exports__.a (datum_transform.js:37)
    at Function.transform (transform.js:57)
    at Object.reproject (CoordinatesUtils.js:164)
    at Object.buildRequest (wms.js:42)
    at buildIdentifyRequest (MapInfoUtils.js:141)
    at eval (identify.js:148)
    at Array.forEach (<anonymous>)
    at Lifecycle.componentWillReceiveProps (identify.js:147)
    at eval (ReactCompositeComponent.js:608)
    at measureLifeCyclePerf (ReactCompositeComponent.js:73)
    at ReactCompositeComponentWrapper.updateComponent (ReactCompositeComponent.js:607)
    at ReactCompositeComponentWrapper.receiveComponent (ReactCompositeComponent.js:544)
    at Object.receiveComponent (ReactReconciler.js:122)
    at ReactCompositeComponentWrapper._updateRenderedComponent (ReactCompositeComponent.js:751)
    at ReactCompositeComponentWrapper._performComponentUpdate (ReactCompositeComponent.js:721)

and also this, sometimes:

Uncaught RangeError: Maximum call stack size exceeded
    at Array.map (<anonymous>)
    at MapPlugin._this.renderLayers (Map.jsx:267)
    at MapPlugin.render (Map.jsx:351)
    at MapPlugin.tryRender (index.js:34)
    at eval (ReactCompositeComponent.js:793)
    at measureLifeCyclePerf (ReactCompositeComponent.js:73)
    at ReactCompositeComponentWrapper._renderValidatedComponentWithoutOwnerOrContext (ReactCompositeComponent.js:792)
    at ReactCompositeComponentWrapper._renderValidatedComponent (ReactCompositeComponent.js:819)
    at ReactCompositeComponentWrapper._updateRenderedComponent (ReactCompositeComponent.js:743)
    at ReactCompositeComponentWrapper._performComponentUpdate (ReactCompositeComponent.js:721)
    at ReactCompositeComponentWrapper.updateComponent (ReactCompositeComponent.js:642)
    at ReactCompositeComponentWrapper.receiveComponent (ReactCompositeComponent.js:544)
    at Object.receiveComponent (ReactReconciler.js:122)
    at ReactCompositeComponentWrapper._updateRenderedComponent (ReactCompositeComponent.js:751)
    at ReactCompositeComponentWrapper._performComponentUpdate (ReactCompositeComponent.js:721)
    at ReactCompositeComponentWrapper.updateComponent (ReactCompositeComponent.js:642)

The application stops working

Duplicated notifications
If you have more than one layer on the map, you will see duplicated warning notification when switch to 3003

WFS table widget

WFS table widget still not working when map viewport is bigger than the world in 4326 (shows an error). Investigate reason and check what to do.

web/client/components/map/openlayers/Layer.jsx

web/client/components/map/openlayers/Map.jsx

web/client/localConfig.json

web/client/plugins/CRSSelector.jsx

offtherailz

Almost done, I think. nice job!

Pending things:

WFS Table : did you investigated on that problem yet?
When I try to load the map in a CRS that is not configured, I have this page:

I'd like instead to see a better explaination. This can be done by managing the exception in a better way:
- When you trigger the exception, do not use only "EPSG:4326" but a full javascript error containing the information you need.
- Add at least an entry to the description when you say that the application don't support the map's EPSG.
When you click 2 times for feature info, the map moves in unexpected way.
Disable the plugin. I see it is automatically disabled when switch to 3D. I think the CRSSelector should also disappear in leaflet map.

baloola · 2019-01-15T07:10:53Z

try to re-configure the 'EPSG:3003' in localConfig.json and it should work.
I will disable the plugin in leaflet.

mbarto · 2019-01-15T08:22:50Z

web/client/components/background/PreviewIcon.jsx

        const containerClass = this.props.vertical ? 'background-preview-icon-container-vertical' : 'background-preview-icon-container-horizontal';
        const type = this.props.layer.visibility ? ' bg-primary' : ' bg-body';
-        const invalid = this.props.layer.invalid ? ' disabled-icon' : '';
+        const invalid = ((validCrs || compatibleWmts || this.props.layer.type === "wms" || this.props.layer.type === "empty") && !this.props.layer.invalid ) ? '' : ' disabled-icon';


I would make this boolean, and calculate the className after.

web/client/components/map/openlayers/Layer.jsx

mbarto · 2019-01-15T08:28:21Z

web/client/components/map/openlayers/Map.jsx

+                let tempCenter = view.getCenter();
+                let projectionExtent = view.getProjection().getExtent();
+                const currentProjectionName = view.getProjection().getCode();
+                if (currentProjectionName === 'EPSG:4326' || currentProjectionName === 'EPSG:900913' || currentProjectionName === 'EPSG:3857') tempCenter[0] = CoordinatesUtils.normalizeLng(tempCenter[0]);


Does this pass ESLint?

actually it does, but I'll refactor it.

web/client/components/map/openlayers/Map.jsx

offtherailz

Please don't re-format files - commit only effective changes:

localConfig.json
icons.less
Vector layer has some problems with projections like 3003. I report the issues I found, probably caused by the same issue:
- in the GetFeatureInfo, using EPSG:3003 the marker goes out of the viewport, while everything else seems to work fine.
- The same of getfeatureinfo is for search:
Switching prj
also annotation have problems, when save

Instead:

advanced filter works well
Switching CRS most of the times works (from 3857 to 4326). The problem seems to appear only in 3003

The rest of the things seems to work.

offtherailz · 2019-01-21T15:45:01Z

I open (#3477) for the pending tasks:

WFS Table do not work when zoom out in 4326
When you try to load the map in a CRS that is not configured, I have a "not found" page

baloola added 5 commits December 7, 2018 12:23

initial

286ecff

initial addition of the CRS selector

e58d2b0

merging update

6630f12

,

af99be1

replacing the crsselector.projection with map.projection

ac94843

ghost assigned baloola Dec 13, 2018

ghost added pending review review labels Dec 13, 2018

baloola requested review from allyoucanmap and mbarto December 13, 2018 10:37

baloola added Project: C042 enhancement Priority: High Task labels Dec 13, 2018

baloola added this to the 2019.01.01 milestone Dec 13, 2018

mbarto reviewed Dec 13, 2018

View reviewed changes

mbarto suggested changes Dec 13, 2018

View reviewed changes

tdipisa modified the milestones: 2019.01.01, 2019.01.00 Dec 18, 2018

baloola added 2 commits December 21, 2018 18:31

additional fixings

cf9ee68

adding additional fixes

8df9ec7

geosolutions-it deleted a comment Jan 4, 2019

tdipisa requested review from offtherailz and removed request for allyoucanmap January 7, 2019 14:54

offtherailz requested changes Jan 7, 2019

View reviewed changes

web/client/components/map/openlayers/Layer.jsx Outdated Show resolved Hide resolved

web/client/components/map/openlayers/Map.jsx Outdated Show resolved Hide resolved

web/client/localConfig.json Outdated Show resolved Hide resolved

offtherailz reviewed Jan 7, 2019

View reviewed changes

web/client/plugins/CRSSelector.jsx Outdated Show resolved Hide resolved

code reviews fixes

3115c31

offtherailz reviewed Jan 14, 2019

View reviewed changes

geosolutions-it deleted a comment Jan 15, 2019

mbarto reviewed Jan 15, 2019

View reviewed changes

mbarto suggested changes Jan 15, 2019

View reviewed changes

tdipisa modified the milestones: 2019.01.00, 2019.01.01 Jan 16, 2019

baloola changed the base branch from master to c042_crs January 16, 2019 11:30

code refactor + click outside extent prevention

7326ee8

offtherailz requested changes Jan 17, 2019

View reviewed changes

baloola added 2 commits January 21, 2019 12:22

reprecting vector layers

1888c34

code enhancement

440bf92

mbarto approved these changes Jan 21, 2019

View reviewed changes

baloola and others added 2 commits January 21, 2019 15:29

remove re-formatted files

7c51515

Update localConfig.json

acbcdbe

ghost assigned offtherailz Jan 21, 2019

offtherailz approved these changes Jan 21, 2019

View reviewed changes

offtherailz merged commit 941ef2a into geosolutions-it:c042_crs Jan 21, 2019

ghost removed pending review review labels Jan 21, 2019

offtherailz mentioned this pull request Feb 1, 2019

Fixes to align WMS gridsets #3505

Merged

5 tasks

offtherailz added a commit that referenced this pull request Feb 1, 2019

Fix #3410 Fixes to align WMS gridsets (#3505)

d44109a

tdipisa modified the milestones: 2019.01.01, 2019.02.00 Feb 15, 2019

This was referenced Dec 24, 2020

[Snyk] Security upgrade axios from 0.18.1 to 0.21.1 t-book/MapStore2#19

Open

[Snyk] Security upgrade axios from 0.11.1 to 0.21.1 carlos-lacerda/MapStore2#8

Open

t-book mentioned this pull request Jan 1, 2024

[Snyk] Security upgrade axios from 0.18.1 to 0.21.1 t-book/MapStore2#87

Open

carlos-lacerda mentioned this pull request Jan 2, 2024

[Snyk] Security upgrade axios from 0.11.1 to 0.21.1 carlos-lacerda/MapStore2#144

Open

t-book mentioned this pull request Mar 15, 2024

[Snyk] Security upgrade axios from 0.18.1 to 0.21.1 t-book/MapStore2#89

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crsselector plugin #3191 #3410

Crsselector plugin #3191 #3410

baloola commented Dec 13, 2018

coveralls commented Dec 13, 2018 •

edited

Loading

mbarto Dec 13, 2018

mbarto Dec 13, 2018

mbarto Dec 13, 2018

mbarto Dec 13, 2018

offtherailz left a comment •

edited

Loading

offtherailz left a comment •

edited

Loading

baloola commented Jan 15, 2019 •

edited

Loading

mbarto Jan 15, 2019

mbarto Jan 15, 2019

baloola Jan 15, 2019

offtherailz left a comment •

edited

Loading

offtherailz commented Jan 21, 2019

Crsselector plugin #3191 #3410

Crsselector plugin #3191 #3410

Conversation

baloola commented Dec 13, 2018

Description

Issues

coveralls commented Dec 13, 2018 • edited Loading

mbarto Dec 13, 2018

Choose a reason for hiding this comment

mbarto Dec 13, 2018

Choose a reason for hiding this comment

mbarto Dec 13, 2018

Choose a reason for hiding this comment

mbarto Dec 13, 2018

Choose a reason for hiding this comment

offtherailz left a comment • edited Loading

Choose a reason for hiding this comment

WFS table widget

offtherailz left a comment • edited Loading

Choose a reason for hiding this comment

baloola commented Jan 15, 2019 • edited Loading

mbarto Jan 15, 2019

Choose a reason for hiding this comment

mbarto Jan 15, 2019

Choose a reason for hiding this comment

baloola Jan 15, 2019

Choose a reason for hiding this comment

offtherailz left a comment • edited Loading

Choose a reason for hiding this comment

offtherailz commented Jan 21, 2019

coveralls commented Dec 13, 2018 •

edited

Loading

offtherailz left a comment •

edited

Loading

offtherailz left a comment •

edited

Loading

baloola commented Jan 15, 2019 •

edited

Loading

offtherailz left a comment •

edited

Loading