Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2602 #2738

Closed
wants to merge 1 commit into from
Closed

fix #2602 #2738

wants to merge 1 commit into from

Conversation

amusso01
Copy link
Contributor

@amusso01 amusso01 commented Mar 13, 2018

Description

Correct the opacity of the loader of the dialog box to display it on loading

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
While uploading local vector loader doesn't appear

What is the new behavior?
Loader appear inside the dialog box while uploading local vector

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes
  • No

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 80.367% when pulling 923c28a on amusso01:working into 5fe67f5 on geosolutions-it:master.

Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most probably the spinner is a component from react spinkit.
see here how to disable spinner initial animation.
You should use it instead of overriding css or you risk disable all the animations for the spinners.
A test in this case should be applied to the specific component instead of the generic dialog.

@chiaracurcio chiaracurcio changed the title fix #2602 fix à2602 Apr 19, 2018
@chiaracurcio chiaracurcio changed the title fix à2602 fix #2602 Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading spinner on import of local vector
4 participants