Fixed #2210 #2327 fixed synch tool and cql_filter creation #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cql_filter creation
# Conflicts: # web/client/epics/featuregrid.js
…dates # Conflicts: # web/client/utils/__tests__/FilterUtils-test.js
offtherailz
reviewed
Nov 27, 2017
| return Rx.Observable.of(addFilterToWMSLayer(layerId, reprojectFilterInNativeCrs(filter, objLayer.nativeCrs))); | ||
| } | ||
| return Rx.Observable.of(addFilterToWMSLayer(layerId, filter)); | ||
| }); |
There was a problem hiding this comment.
I think here a takeUntil is needed to stop monitoring.
What if you stop and sync and change filter?
There was a problem hiding this comment.
it does not reach this point because in the merge function it checks if the sync is active or is being activated in that moment.
offtherailz
approved these changes
Nov 27, 2017
offtherailz
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cql Filter was wrongly created if a spatial filter was present. the crs was not the native one of the layer
Also for 0 value in numeric editors creates problem and the use of ID and other attributes.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Actually the layer is correctly filtered in the three cases and for all their combinations.
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other information:
For testing this try to draw a spatial filter and then activate the sync. the features should be filtered based on the drawn spatial filter.
NOTE: ID and all reserved keyword must be wrapped by "" in order to parse correctly the cql_filter parameter