Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #2210 cql creation related to the synch tool #2402

Closed
wants to merge 6 commits into from

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Nov 16, 2017

Description

Cql Filter was wrongly created if a spatial filter was present. the crs was not the native one of the layer

Issues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior? (You can also link to an open issue here)
if sync wasa active and it was drawn a spatial filter then the layer were hidden. (cql messed up)

What is the new behavior?
actually the layer is correctly filtered.

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Maybe

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
I'm not sure 100% that this PR introduces a breaking change in the projects that uses this. There could be some problem related to the fix made in drawsupport when a polygon is drawn because in ol it was missing the last vertix

Other information:
For testing this try to draw a spatial filter and then activate the sync. the features should be filtered based on the drawn spatial filter.

@MV88 MV88 self-assigned this Nov 16, 2017
@MV88 MV88 requested review from offtherailz and mbarto November 16, 2017 10:55
@ghost ghost added In Test labels Nov 16, 2017
@MV88 MV88 changed the title Fixed #2210 cql creation for spatial filter in ol Fixed #2210 cql creation related to the synch tool Nov 16, 2017
@MV88 MV88 removed the In Test label Nov 16, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 80.683% when pulling 46b25ca on MV88:2210_synch_featuregrid into a5059e9 on geosolutions-it:master.

@MV88
Copy link
Contributor Author

MV88 commented Nov 16, 2017

Just discovered a problem related to the fact that nativeCrs definition for proj4 could be missing and this leads to some error we need to handle as first thing.
we can consider other solutions (fetch dinamically the proj definition) but I need help with this.
@mbarto @offtherailz @tdipisa opinions?

@MV88
Copy link
Contributor Author

MV88 commented Nov 17, 2017

Closing temporarily because i need to provide other changes

@MV88 MV88 closed this Nov 17, 2017
@ghost ghost removed the in progress label Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync map with Filter sometimes disables the layer
2 participants